Skip to content

RDKEMW-1000 : Add COM-RPC support to UnifiedCASManagement plugin#719

Open
naveen-0206 wants to merge 3 commits intodevelopfrom
feature/unified_apis_jan_27
Open

RDKEMW-1000 : Add COM-RPC support to UnifiedCASManagement plugin#719
naveen-0206 wants to merge 3 commits intodevelopfrom
feature/unified_apis_jan_27

Conversation

@naveen-0206
Copy link
Contributor

Reason For Change: Adding UnifiedCASManagement interface header Changes
Test procedure : Test UnifiedCASManagement
Priority: P1

@naveen-0206 naveen-0206 requested a review from a team as a code owner January 27, 2026 10:40
Copilot AI review requested due to automatic review settings January 27, 2026 10:40
@github-actions
Copy link

Documentation Auto-Generated

Documentation has been automatically generated for the changed plugins and committed to this PR branch.

The generated documentation files have been added to the PR for review.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new COM-RPC interface for UnifiedCASManagement and wires it into the shared ID registry so it can be exposed as a Thunder/JSON-RPC plugin.

Changes:

  • Added IUnifiedCASManagement COM-RPC interface with registration, Manage, Unmanage, Send APIs, and a CAS data notification event, including JSON-RPC tagging.
  • Added corresponding ID_UNIFIEDCASMANAGEMENT and ID_UNIFIEDCASMANAGEMENT_NOTIFICATION entries in apis/Ids.h to allocate unique interface and notification IDs.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.

File Description
apis/UnifiedCASManagement/IUnifiedCASManagement.h Defines the new UnifiedCASManagement COM-RPC interface, notification event, and JSON-RPC metadata for CAS management and messaging.
apis/Ids.h Reserves unique IDS values for the UnifiedCASManagement interface and its notification to integrate with the global COM-RPC ID space.

@naveen-0206 naveen-0206 force-pushed the feature/unified_apis_jan_27 branch from 2a5a184 to 1dcbee2 Compare January 27, 2026 11:01
@github-actions
Copy link

Documentation Auto-Generated

Documentation has been automatically generated for the changed plugins and committed to this PR branch.

The generated documentation files have been added to the PR for review.

Copilot AI review requested due to automatic review settings January 27, 2026 11:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

@naveen-0206 naveen-0206 force-pushed the feature/unified_apis_jan_27 branch from 648b364 to 56eb3f1 Compare February 5, 2026 09:19
Copilot AI review requested due to automatic review settings February 5, 2026 09:19
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Documentation Auto-Generated

Documentation has been automatically generated for the changed plugins and committed to this PR branch.

The generated documentation files have been added to the PR for review.

@naveen-0206 naveen-0206 requested review from Copilot and removed request for Copilot February 5, 2026 09:20
@naveen-0206 naveen-0206 force-pushed the feature/unified_apis_jan_27 branch from 207eae5 to 4145750 Compare February 10, 2026 05:02
@naveen-0206 naveen-0206 requested review from Copilot and removed request for Copilot February 10, 2026 05:02
@github-actions
Copy link

Documentation Auto-Generated

Documentation has been automatically generated for the changed plugins and committed to this PR branch.

The generated documentation files have been added to the PR for review.

Copilot AI review requested due to automatic review settings February 10, 2026 05:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI review requested due to automatic review settings February 13, 2026 11:37
@naveen-0206 naveen-0206 force-pushed the feature/unified_apis_jan_27 branch from 50a83b5 to 353638a Compare February 13, 2026 11:37
@naveen-0206 naveen-0206 review requested due to automatic review settings February 13, 2026 11:37
@naveen-0206 naveen-0206 force-pushed the feature/unified_apis_jan_27 branch from 353638a to 0e41656 Compare February 13, 2026 11:40
Copilot AI review requested due to automatic review settings February 13, 2026 11:40
@github-actions
Copy link

Documentation Auto-Generated

Documentation has been automatically generated for the changed plugins and committed to this PR branch.

The generated documentation files have been added to the PR for review.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

apis/Ids.h:342

  • New IDS enum constants ID_UNIFIEDCASMANAGEMENT / ID_UNIFIEDCASMANAGEMENT_NOTIFICATION do not follow the ALL_UPPER_SNAKE_CASE enum naming guideline (words should be separated with underscores). Since these IDs are newly introduced, it would be best to rename them to something like ID_UNIFIED_CAS_MANAGEMENT and ID_UNIFIED_CAS_MANAGEMENT_NOTIFICATION (and update the interface header accordingly) before they become part of the public API surface.

Refer: https://github.com/rdkcentral/entservices-apis/blob/develop/.github/instructions/api_headers.instructions.md#enum-naming


        ID_GOOGLE_CAST                               = ID_ENTOS_OFFSET + 0x470,

@naveen-0206 naveen-0206 force-pushed the feature/unified_apis_jan_27 branch from afa83df to bbb43f6 Compare February 17, 2026 05:23
@github-actions
Copy link

Documentation Auto-Generated

Documentation has been automatically generated for the changed plugins and committed to this PR branch.

The generated documentation files have been added to the PR for review.

Copilot AI review requested due to automatic review settings February 17, 2026 05:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@naveen-0206 naveen-0206 force-pushed the feature/unified_apis_jan_27 branch from 94b6aa9 to 046829b Compare February 17, 2026 07:58
@github-actions
Copy link

Documentation Auto-Generated

Documentation has been automatically generated for the changed plugins and committed to this PR branch.

The generated documentation files have been added to the PR for review.

Copilot AI review requested due to automatic review settings February 17, 2026 07:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@naveen-0206 naveen-0206 force-pushed the feature/unified_apis_jan_27 branch from ef48220 to ecf8e9f Compare February 17, 2026 08:07
@github-actions
Copy link

Documentation Auto-Generated

Documentation has been automatically generated for the changed plugins and committed to this PR branch.

The generated documentation files have been added to the PR for review.

Copilot AI review requested due to automatic review settings February 17, 2026 08:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@naveen-0206 naveen-0206 force-pushed the feature/unified_apis_jan_27 branch from 9324169 to 5e3cc5f Compare February 18, 2026 09:35
Reason For Change: Adding UnifiedCASManagement interface header Changes
Test procedure : Test UnifiedCASManagement
Priority: P1

Signed-off-by: naveen-0206 <naveenkumar.t@ltts.com>
Copilot AI review requested due to automatic review settings February 18, 2026 09:39
@naveen-0206 naveen-0206 force-pushed the feature/unified_apis_jan_27 branch from 5e3cc5f to f3d4cc6 Compare February 18, 2026 09:39
@github-actions
Copy link

Documentation Auto-Generated

Documentation has been automatically generated for the changed plugins and committed to this PR branch.

The generated documentation files have been added to the PR for review.

@naveen-0206 naveen-0206 review requested due to automatic review settings February 18, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants